Update the component template docs preview command #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/update-component-template-make-docs-serve
branch
from
7db7ca8 to
5bd4885
Compare
3 tasks
bastjan
approved these changes
Feb 7, 2022
This was referenced Feb 7, 2022
This commit: * Bumps Antora preview command docker image to vshn/antora-preview:3.0.0.1. This gives us a Antora preview which auto-refreshes the docs while the command is running and updates the image to one which contains the current VSHN Kroki instance URL. * Only mounts `<component-dir>/docs` and `<component-dir>/.git` into the Docker container. This should avoid issues with Antora getting confused about paths in `vendor` not being readable in the container. * Exposes port 35729 of the Docker container for the auto-reload browser plugin. See also projectsyn/modulesync-control#59
simu
force-pushed
the
feat/update-component-template-make-docs-serve
branch
from
5bd4885 to
a04cfb9
Compare
simu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
<component-dir>/docsand<component-dir>/.gitinto the Docker container. This should avoid issues with Antora getting confused about paths invendornot being readable in the container.See also projectsyn/modulesync-control#59
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog