Improve error messages for duplicate component aliases #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logic to detect component aliases which alias another component used in the hierarchy. To do this, we validate discovered components and aliases after parsing all `applications` array entries. This also allows us to provide all components which illegally map to the same alias. The errors are still raw `KeyError` exceptions when running `commodore catalog compile`. Fixes #344
…ents` Raise a `ClickException` instead to produce a nice error message.
simu
force-pushed
the
fix/component-alias-error-message
branch
from
6b8f405 to
814180f
Compare
glrf
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logic to detect component aliases which alias another component used in the hierarchy.
To do this, we validate discovered components and aliases after parsing all
applicationsarray entries. This also allows us to provide all components which illegally map to the same alias.The errors are still raw
KeyErrorexceptions when runningcommodore catalog compile.Fixes #344
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog