Exclude jsonnet files from indent linter #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvus-ch
approved these changes
Aug 24, 2021
glrf
approved these changes
Aug 24, 2021
bastjan
force-pushed
the
bastjan-patch-1
branch
from
6ac70da to
6374ad4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonnetfmtalready has a very opinionated formatter, which makes the linter superfluous and can lead to conflicts betweenjsonnetfmtandeditorconfiglinters.See: https://github.com/projectsyn/component-backup-k8up/pull/36/checks?check_run_id=3221663321#step:3:10
It hit us again yesterday while onboarding https://github.com/projectsyn/component-system-upgrade-controller and today in https://github.com/projectsyn/component-kyverno. It is not possible to make both the jsonnet formatter and the editorconfig indent linter happy at the same time without ugly workarounds (putting everything in one line, append a character to the variable to get the correct indentation).
Checklist