Component delete command #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srueg
suggested changes
Sep 17, 2020
srueg
approved these changes
Sep 17, 2020
simu
approved these changes
Sep 18, 2020
Commodore already had a 'component new' command, this commit introduces a new 'delete' counterpart that will cleanly remove a component (identified by a slug) from the current catalog.
os.system() returns a number that is a (binary) mix between the syscall that terminated the program and its exit code. In case of successful program exit, there is no difference, but in case of error exit, the result needs to be binary shifted (or masked) to get the actual exit code. This branch switches to using the recommended way to call a shell command in python3 instead (subprocess.call()). See https://docs.python.org/3/library/os.html#os.system for more context.
The name didn't reflect the focus of the file anymore.
The code is smart enough to do that for the user now, the warning is not needed anymore.
Renaming the file did cause more fallout than expected.
chrisglass
force-pushed
the
component-delete-command
branch
from
5b8be28 to
d965518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a
component delete <slug>command to commodore.It does the opposite of
component add <slug>:It also introduces a
--forceparameter in case the interactive confirmation is not desired (for scripts, for instance):Checklist