Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate new component slug #153

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Validate new component slug #153

merged 1 commit into from
Jul 29, 2020

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Jul 29, 2020

Prevent components having the component- prefix in their slug.

Closes #152

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update tests.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

Validate new component slug
03a7097 
Prevent components having the `component-` prefix in their slug.

Closes #152
@srueg srueg force-pushed the fix/component-slug branch from 9dc8eae to 03a7097 Compare July 29, 2020 07:00
@srueg srueg requested review from simu and akosma July 29, 2020 07:00
akosma
akosma approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@akosma akosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot

@srueg srueg merged commit ce43022 into master Jul 29, 2020
@srueg srueg deleted the fix/component-slug branch July 29, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

@akosma akosma akosma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot compile a component created with Docker named "component-name"
3 participants
@srueg @akosma @simu