Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more derived State classes to be parameterized with a generic type #1022

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

jeevcat
Copy link
Contributor

@jeevcat jeevcat commented Dec 16, 2023

Checklist

  • The tests pass
  • I have referenced the issue(s) or other PR(s) this fixes/relates-to
  • I have run pnpm changeset and followed the instructions
  • I have explained in this PR, what I did and why
  • I replaced the image below
  • Had a beer/coffee/tea because I did something cool today

What, why and how?

Prevent the need to do type assertions on the engine member on a number of classes which derive from State by adding a generic parameter which is passed to the derived class.

Feel good image:

noice

Copy link

changeset-bot bot commented Dec 16, 2023

🦋 Changeset detected

Latest commit: 09ed60f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@projectstorm/react-canvas-core Patch
@projectstorm/react-diagrams-core Patch
@projectstorm/react-diagrams-defaults Patch
@projectstorm/react-diagrams-routing Patch
@projectstorm/react-diagrams Patch
@projectstorm/react-diagrams-gallery Patch
@projectstorm/react-diagrams-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylanvorster dylanvorster merged commit 8031008 into projectstorm:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants