Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash imports to use individual functions #1021

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

LynchyC
Copy link
Contributor

@LynchyC LynchyC commented Nov 8, 2023

Checklist

  • The tests pass
  • I have referenced the issue(s) or other PR(s) this fixes/relates-to
  • I have run pnpm changeset and followed the instructions
  • I have explained in this PR, what I did and why
  • I replaced the image below
  • Had a beer/coffee/tea because I did something cool today

What, why and how?

Currently, the project is bringing in lodash functions the standard way i.e. (import _ from lodash or import * as _ from 'lodash').

This is just a small quality of life improvement to lessen the footprint of the overall library when bundled into others apps.

Feel good image:

dog-perfect-smile-doesnt-exi

Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: 80285fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@projectstorm/react-diagrams-gallery Patch
@projectstorm/geometry Patch
@projectstorm/react-canvas-core Patch
@projectstorm/react-diagrams-core Patch
@projectstorm/react-diagrams-defaults Patch
@projectstorm/react-diagrams-routing Patch
@projectstorm/react-diagrams Patch
@projectstorm/react-diagrams-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LynchyC
Copy link
Contributor Author

LynchyC commented Nov 8, 2023

If you would rather prefer, I can instead update the repo to use the lodash-es dependency?

@dylanvorster dylanvorster merged commit 78d10b8 into projectstorm:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants