-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default link widget with react strict mode #1014
Conversation
🦋 Changeset detectedLatest commit: 20766f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hello @marian2js Could you help me? How would I include your fork into my project? I've tried several ways, pulling the npm from your git, but the library is not recognized in the code as a package. |
Without having the pull request go through, I think the best way would be to use pnpm and copy all the code as packages within a monorepo. |
can you help me about doing with the steps of doing it, I don't know much changeset and how do i use these in my library? |
@dylanvorster would it be possible to get this pr reviewed? |
Sorry this took so long everyone, and thanks for the work on this PR :) |
Thanks so much! |
@dylanvorster I think this may have broken links altogether. Something must have changed when pulling in the newer versions of core and canvas in the same release. |
I did check each PR on my own machine with storybook, lemme take another look |
looks like the custom demos are broken, but the gallery (which is deployed automatically on release) seems to work, @ericlarssen can you elaborate a bit? |
Checklist
pnpm changeset
and followed the instructionsWhat, why and how?
Solves #598, #618, #653, and #967 (the closed ones are closed with the workaround of removing strict mode).
React Strict Mode is recommended on production, DefaultLinkWidget was changing the component's state on render, which is not recommended by React. I refactored the component to use hooks, so now can be used with strict mode.
Feel good image: