Replace usage of deprecated ConfigProperties with ConfigMapping #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Aug 23, 2021
servers/quarkus-server/src/main/java/org/projectnessie/server/config/QuarkusServerConfig.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1814 +/- ##
============================================
+ Coverage 75.55% 75.57% +0.02%
Complexity 2300 2300
============================================
Files 303 303
Lines 14582 14582
Branches 1067 1067
============================================
+ Hits 11017 11020 +3
+ Misses 3089 3086 -3
Partials 476 476
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dimas-b
previously approved these changes
Aug 23, 2021
nastra
force-pushed
the
quarkus-deprecated-config-properties
branch
from
13e23dd to
525ddef
Compare
dimas-b
approved these changes
Aug 24, 2021
nastra
commented
Aug 25, 2021
| @@ -155,7 +155,7 @@ | |||
| <openapi.version>2.0</openapi.version> | |||
| <prometheus.version>0.9.0</prometheus.version> | |||
| <protobuf.version>3.17.3</protobuf.version> | |||
| <quarkus.version>2.1.3.Final</quarkus.version> | |||
| <quarkus.version>2.2.0.CR1</quarkus.version> | |||
There was a problem hiding this comment.
2.2.0.Final should be released today, so we/dependabot can switch to that new version then
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 14, 2021
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is