Added homophily ratio in basic schelling example #2520
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
vbv-shm
changed the title
vbv-shm
changed the title
for more information, see https://pre-commit.ci
| @@ -13,7 +13,7 @@ def __init__( | |||
| width: int = 40, | |||
| density: float = 0.8, | |||
| minority_pc: float = 0.5, | |||
| homophily: int = 3, | |||
| homophily_ratio: float = 0.3, | |||
There was a problem hiding this comment.
why 0.3? It would make more sense to go to 3/8 (8 is the neighborhood size of a Moore grid with a radius of 1 and all fields occupied.
There was a problem hiding this comment.
Thank you for reviewing. I will change 0.3 to 3/8 (0.375).
There was a problem hiding this comment.
@quaquel The step size of the slider is 0.1. So the ratio can either be 0.3 or 0.4.
If the ratio is 0.3, agents with 3 similar neighbors and 8 total neighbors will be happy, as 3/8 = 0.375.
And if the ratio is 0.4, agents with 3 similar neighbors and 8 total neighbors won't be happy.
So should I change 0.3 to 0.4?
There was a problem hiding this comment.
Maybe we can change the step size to 0.125 as well?
|
Thanks for the PR! Could you update your PR description to contain all the necessary information to understand this change on its own? You can use this template if you want. Edit: I saw there's also this PR open, which also modifies schelling: Are there any conflicts between them? I would tend to let #2518 go first, since it was opened earlier. (or did we assign someone to this specific issue?) |
|
@EwoutH Thank you for the reply. |
|
I have provided feedback in #2518, if that is not addressed in the coming days and there is no further response, I am fine with merging this instead. |
|
@quaquel Thank you. I understand. |
EwoutH
added
trigger-benchmarks
Changed homophily comparing logic as per discussion in #2515.
Now homophily_ratio is checked for agents to be happy. homophily_ratio is similar neighboring agents divided by the total number of neighbors.