-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework messages serialization #352
Merged
Merged
Changes from 26 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b317a6d
Optimize replication message packing
Shatur 396d91b
Fix doc tests
Shatur c1bb570
Add a test for many entities
Shatur 2f727b7
Replace many entities test with many components
Shatur 098e18d
Merge remote-tracking branch 'origin/master' into ser-de-rework
Shatur 4fe95b3
Rename `InitMessageHeader` into `InitMessageArrays`
Shatur 972ab21
Swap order of `InitMessage::is_empty` checks
Shatur 44270cc
Use "mutation" instead of "change" for update message for clarity
Shatur b40cab4
Don't serialize size for last array inside init message
Shatur a148ab1
Rename `UpdateMessage` into `MutateMessage`
Shatur e443c8b
Rename `InitMessage` into `ChangeMessage`
Shatur 05336f8
Rename mutate_timeout into mutations_timeout
Shatur 1fcee8b
Improve trace message
Shatur 751e25a
Update docs
Shatur 4fb17d2
Serialize array len for nested arrays of change message
Shatur 6751dc2
Split `apply_array` to avoid having confusing bool arg
Shatur 713f645
Add a test for removal with despawn
Shatur 6558824
Assert if the message is empty
Shatur a37d3ca
Always include size for mappings
Shatur 9f204f8
Rename `InitMessageArrays` into `InitMessageFlags`
Shatur 397a18c
Print the number of mutate messages sent
Shatur b866310
Merge remote-tracking branch 'origin/master' into ser-de-rework
Shatur 9eb97cb
Merge branch 'master' into ser-de-rework
Shatur 6c1c60f
Merge branch 'master' into ser-de-rework
Shatur 024829f
Merge branch 'master' into ser-de-rework
Shatur 07be709
Apply doc suggestions from code review [skip ci]
Shatur 50df358
Do not use varints for acks
Shatur 09a6340
Don't use varint encoding for ticks
Shatur 75683ed
Use guarded return
Shatur ccb1848
Refactor `take_mutations`
Shatur 949a060
Add more assertions
Shatur 42067db
Use a single function to apply array
Shatur 2ad7a4a
Bring back `can_pack`
Shatur 98c7404
Refactor the packing logic
Shatur d317805
Merge remote-tracking branch 'origin/master' into ser-de-rework
Shatur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this instead? It would disambiguate the message type from the internal subsection called 'changes'.
Changes
also seems slightly off to me for the message name.If you agree, let's change it in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!