Cancel the requestAnimationFrame when all roots are disconnected
#633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
approved these changes
Jun 25, 2024
Given that `pendingElements` was already being cleared, just below, there won't be anything to translate and as far as I can tell keeping the `requestAnimationFrame` running shouldn't be necessary. Note that this was found in the PDF.js project, please refer to [this discussion](mozilla/pdf.js#18313 (comment)), where we're trying to shutdown various asynchronous operations when running tests and currently Fluent make this difficult.
Snuffleupagus
force-pushed
the
disconnectRoot-cancelAnimationFrame
branch
from
3ce06a5
to
b8142ec
Compare
|
@eemeli would you mind to make a new release please ? |
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
pendingElementswas already being cleared, just below, there won't be anything to translate and as far as I can tell keeping therequestAnimationFramerunning shouldn't be necessary.Note that this was found in the PDF.js project, please refer to this discussion, where we're trying to shutdown various asynchronous operations when running tests and currently Fluent make this difficult.
/cc @calixteman, @timvandermeij