Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compat.js; compile index.cjs to ES2018 #479

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Remove compat.js; compile index.cjs to ES2018 #479

merged 1 commit into from
Apr 21, 2020

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Apr 20, 2020

Fix #472.

@stasm
Copy link
Contributor Author

stasm commented Apr 21, 2020 •
edited
Loading

As expected, there are no differences across all packages between index.js produced with target: "ES2019" (master) and index.js produced with target: "ES2018" (this PR).

I also ran the diff between master's compat.js files, and the new index.js ones: https://gist.github.com/stasm/c4e167711cb2678a014445d82ae7e92c

@stasm stasm requested a review from Pike April 21, 2020 13:11
@stasm stasm merged commit c27994d into projectfluent:master Apr 21, 2020
@stasm stasm deleted the es2018 branch April 21, 2020 14:46
This was referenced Jul 6, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pike Pike Pike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove compat.js build artifacts
2 participants
@stasm @Pike