fix fetchParams func #301
Closed
fix fetchParams func #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunKoyalwar
requested changes
Jan 3, 2024
Comment on lines
214
to
225
| return | ||
| } else { | ||
| encodedParams := u.Original[index+1:] | ||
| if encodedParams == "" { | ||
| return | ||
| } | ||
| u.Params.Decode(encodedParams) | ||
| u.Original = u.Original[:index] | ||
| } | ||
| u.Update() | ||
| } | ||
|
|
There was a problem hiding this comment.
@dogancanbakir if encodedParams is empty and we return early then ? will be considered as part of path and it might break MergePath when in unsafe mode. since the goal of fetchParams is to remove parameters completely from url for furthur processing . we can instead add new parameter in orderParam like IncludePrefix for this special case
Line 14 in 79cdbbc
(OrderedParams).Encode() while constructing QueryParamString in url and this will be reflected in all downstream dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300