Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dedupe #261

Merged
merged 3 commits into from
Oct 24, 2023
Merged

add dedupe #261

merged 3 commits into from
Oct 24, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Sep 25, 2023 •
edited
Loading

Closes #256.

@dogancanbakir dogancanbakir self-assigned this Sep 25, 2023
@tarunKoyalwar tarunKoyalwar linked an issue Sep 25, 2023 that may be closed by this pull request
dedup utils #256
Closed
tarunKoyalwar
tarunKoyalwar reviewed Sep 27, 2023
View reviewed changes
dedupe/dedupe.go Outdated Show resolved Hide resolved
tarunKoyalwar
tarunKoyalwar reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should modify it to return a stream of unique elements rather than final results ( optional + configurable )

tarunKoyalwar
tarunKoyalwar requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

suggesting minor change to make unique data stream optional

dedupe/dedupe.go Outdated Show resolved Hide resolved
@Mzack9999 Mzack9999 merged commit 7dfa4e9 into main Oct 24, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the add_dedupe branch October 24, 2023 08:24
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@dogancanbakir dogancanbakir

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dedup utils
3 participants
@dogancanbakir @Mzack9999 @tarunKoyalwar