Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cert usage #201

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Fix/cert usage #201

merged 3 commits into from
Dec 14, 2022

Conversation

Kelfitas
Copy link
Contributor

Proposed changes

Hi there, I tried to use proxify with Chrome and cert was rejected with the following error even tho the CA was installed on the system:

[53853:19971:1214/001611.870452:ERROR:ssl_client_socket_impl.cc(982)] handshake failed; returned -1, SSL error code 1, net_error -207
[53828:64003:1214/001611.988957:ERROR:cert_verify_proc_builtin.cc(670)] CertVerifyProcBuiltin for www.google.com failed:
----- Certificate i=0 (CN=www.google.com,O=Proxify CA,2.5.4.17=#3934313034,2.5.4.9=#353438204D61726B6574205374,L=San Francisco,ST=CA,C=US) -----
ERROR: Target certificate looks like a CA but does not set all CA properties

After some digging, I found this link - https://support.google.com/chrome/thread/184774585?hl=en&msgid=186173470, changed the cert KeyUsage (removed CertSign), tested again with Chrome and it worked!

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelfitas thank you for fixing this one.

@ehsandeep ehsandeep merged commit 6993654 into projectdiscovery:dev Dec 14, 2022
@Kelfitas Kelfitas deleted the fix/cert-usage branch December 14, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants