Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing response content length calculation #133

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fixing response content length calculation #133

merged 1 commit into from
Jun 13, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jun 13, 2022 •
edited
Loading

Proposed changes

This PR fixes the response content body calculation if it gets modified by DSL language

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Example

$ go run . -response-match-replace-dsl "replace_regex(response, 'authentication failed', 'authentication ok')"

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 13, 2022
@Mzack9999 Mzack9999 self-assigned this Jun 13, 2022
@Mzack9999 Mzack9999 requested a review from ehsandeep June 13, 2022 13:44
@ehsandeep ehsandeep merged commit 6d01c81 into dev Jun 13, 2022
@ehsandeep ehsandeep deleted the maint-resp-content-length-fix branch June 13, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mzack9999 @ehsandeep