Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ update to current versions of some actions #1242

Merged
merged 8 commits into from
Oct 21, 2024
Merged

⬆️ update to current versions of some actions #1242

merged 8 commits into from
Oct 21, 2024

Conversation

thomasmerz
Copy link
Contributor

No description provided.

dependabot bot and others added 7 commits March 13, 2024 22:59
@dependabot
chore(deps): bump google.golang.org/protobuf in /v2
087e5ff 
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Merge pull request #995 from projectdiscovery/dependabot/go_modules/v…
7fbea0d 
…2/google.golang.org/protobuf-1.33.0
@dependabot
chore(deps): bump github.com/quic-go/quic-go in /v2
0e46b62 
Bumps [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) from 0.38.2 to 0.42.0.
- [Release notes](https://github.com/quic-go/quic-go/releases)
- [Changelog](https://github.com/quic-go/quic-go/blob/master/Changelog.md)
- [Commits](quic-go/quic-go@v0.38.2...v0.42.0)

---
updated-dependencies:
- dependency-name: github.com/quic-go/quic-go
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Merge pull request #1021 from projectdiscovery/dependabot/go_modules/…
a6e89fa 
…v2/github.com/quic-go/quic-go-0.42.0
@dependabot
chore(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 in /v2
cc7054f 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.22.0 to 0.23.0.
- [Commits](golang/net@v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Merge pull request #1033 from projectdiscovery/dependabot/go_modules/…
18dc537 
…v2/golang.org/x/net-0.23.0
@ehsandeep
Merge branch 'dev'
10f5605
@thomasmerz
Copy link
Contributor Author

I read about your little tool in german "Linux User" on page 8 😃 and I wanted to use it, but I had to do some fixes to make it work (as GitHub Action)…

@ehsandeep ehsandeep requested a review from Mzack9999 October 16, 2024 14:52
@Mzack9999 Mzack9999 changed the base branch from main to dev October 16, 2024 22:06
Mzack9999
Mzack9999 reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasmerz Thanks for the PR! Various GH actions should be already updated in the dev branch which contains all the latest developments, they are just not released in the main branch yet.
Before bumping the go version could you share more insights about why go 1.21 is not working in GH actions?

@thomasmerz
Copy link
Contributor Author

thomasmerz commented Oct 18, 2024 •
edited
Loading

Before bumping the go version could you share more insights about why go 1.21 is not working in GH actions?

GH actions also works with go 1.21 - but I thought it might be ok to also use a more current minor version that doesn't break anything. See my test-run in my private sandbox-repo for testing:

image

Is it ok for you to also update go version or should I revert to 1.21.x or/and put it into a new PR?

@ehsandeep
Copy link
Member

@thomasmerz, we can revert this to 1.21.x. We have multiple projects using each other as dependency projects, so we’re looking to stick to a specific version unless a feature requires an update for implementation in the tool.

@thomasmerz thomasmerz changed the title ⬆️ update to current versions of some actions and go-version ⬆️ update to current versions of some actions Oct 21, 2024
@thomasmerz
Copy link
Contributor Author

@ehsandeep , I reverted go version to 1.21.x.

@ehsandeep ehsandeep merged commit 0b2c6ef into projectdiscovery:dev Oct 21, 2024
4 checks passed
@thomasmerz thomasmerz deleted the update_dependencies branch October 25, 2024 14:58
@BrewTestBot BrewTestBot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 left review comments

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasmerz @ehsandeep @Mzack9999 @dogancanbakir