Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DefaultClient in asn package #144

Merged
merged 10 commits into from
Feb 13, 2023
Merged

Implement DefaultClient in asn package #144

merged 10 commits into from
Feb 13, 2023

Conversation

xm1k3
Copy link
Contributor

@xm1k3 xm1k3 commented Jan 25, 2023

No description provided.

@xm1k3 xm1k3 changed the base branch from master to dev January 25, 2023 21:04
@xm1k3 xm1k3 self-assigned this Jan 25, 2023
@xm1k3 xm1k3 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 25, 2023
@xm1k3 xm1k3 linked an issue Jan 25, 2023 that may be closed by this pull request
Create a global default asn.DefaultClient #138
Closed
@Mzack9999
Copy link
Member

Tests failure depends on projectdiscovery/asnmap#49

ehsandeep
ehsandeep requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xm1k3 can you pull the latest version of asnmap to ensure builds are passing?

@xm1k3 xm1k3 requested a review from ehsandeep February 9, 2023 22:22
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Mzack9999 Mzack9999 mentioned this pull request Feb 13, 2023
Merged
@Mzack9999 Mzack9999 merged commit 72e91b7 into dev Feb 13, 2023
@Mzack9999 Mzack9999 deleted the issue-138-default-client branch February 13, 2023 07:11
@francisuk1989
Copy link

francisuk1989 commented Feb 25, 2023 •
edited
Loading

I had this idea #137 as i have my own RIPE database on a local server as RIPE search is limited.

Something like this to grab the IPs from AS206067 e.g

./mapcidr -asnurl http://myripedatabaseserver/?get=AS206067 -aggregate >> Firewall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@xm1k3 xm1k3

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a global default asn.DefaultClient
4 participants
@xm1k3 @Mzack9999 @francisuk1989 @ehsandeep