Fix ANY queries and TCP socket for DNS #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up both TCP and UDP DNS servers, which should allow for the occasional case where a TCP query can make it to the server but UDP can't, and fixes support for ANY queries. ANY queries are deprecated in RFC8482 but this may also provide for additional interaction opportunities. Re-organises the error handling around DNS server creation slightly because 'error' was always returned as nil anyway.
ehsandeep
requested review from
ehsandeep,
Mzack9999 and
Ice3man543
and removed request for
ehsandeep
Mzack9999
approved these changes
Jan 13, 2022
Ice3man543
approved these changes
Jan 13, 2022
ehsandeep
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up both TCP and UDP DNS servers, which should allow for the occasional case where a TCP query can make it to the server but UDP can't, and fixes support for ANY queries. ANY queries are deprecated in RFC8482 but this may also provide for additional interaction opportunities.
Re-organises the error handling around DNS server creation slightly because
errorwas always returned asnilanyway.