Use certmagic + bugfixing for DNS server #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 2, 2022
Forwarder DNS can't parse correctly NS authorithative entries leading to NS propagation failure
#137
Closed
Ice3man543
added
the
Status: Review Needed
|
This doesn't work on interactsh.com server probably on account of quad9 blocking interactsh.com here. On other tested setups, it's confirmed to work correctly. |
Mzack9999
approved these changes
Jan 4, 2022
ehsandeep
added
Status: Completed
ehsandeep
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using certmagic from caddyserver for the ACME library, which is a very battle-hardened solution and supports multiple edge cases of the ACME protocol which the previous client failed with.
In addition, a few bugs have been fixed in the DNS module which were also potentially related with the ACME registrations failing.
For the case sensitive problem, the normalization has been added at unique ID level which should not cause any problems with case-sensitive DNS queries.