Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump to go 1.17 and update docker image #396

Merged
merged 4 commits into from
Sep 13, 2021
Merged

build: bump to go 1.17 and update docker image #396

merged 4 commits into from
Sep 13, 2021

Conversation

chenrui333
Copy link
Contributor

No description provided.

@chenrui333 chenrui333 changed the title build: bump to go 1.17 build: bump to go 1.17 and update docker image Sep 9, 2021
Mzack9999
Mzack9999 reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few observations:

  • The PR should point to dev branch
  • The name attribute of the build steps was removed because redundant?

@ehsandeep ehsandeep changed the base branch from master to dev September 13, 2021 08:57
@ehsandeep ehsandeep merged commit 6f50be2 into projectdiscovery:dev Sep 13, 2021
@ehsandeep
Copy link
Member

@Mzack9999 thank you for pointing it out.

  1. Pointed the PR the dev branch
  2. I assume, it is updated as it's an optional attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 left review comments

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @ehsandeep @Mzack9999