Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding string/regex match/filter #110

Merged
merged 5 commits into from
Sep 16, 2020
Merged

adding string/regex match/filter #110

merged 5 commits into from
Sep 16, 2020

Conversation

Mzack9999
Copy link
Member

No description provided.

@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Type: Enhancement Most issues will probably ask for additions or changes. labels Sep 14, 2020
@Mzack9999 Mzack9999 self-assigned this Sep 14, 2020
@Mzack9999 Mzack9999 linked an issue Sep 14, 2020 that may be closed by this pull request
Feature request: string/regex search in response bodies #97
Closed
@ehsandeep
Copy link
Member

@Mzack9999 Can you share an example for this? Following command return blank.

$ echo hackerone.com | ./httpx -match-string hackerone -silent

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed Type: Enhancement Most issues will probably ask for additions or changes. labels Sep 15, 2020
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Sep 15, 2020
@ehsandeep
Copy link
Member

This needs more testing, as this is still not working in the expected way.

@ehsandeep ehsandeep merged commit d26783f into master Sep 16, 2020
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Sep 16, 2020
@ehsandeep ehsandeep deleted the feature-string-regex-match branch September 17, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: string/regex search in response bodies
2 participants
@Mzack9999 @ehsandeep