Merge pull request #2 from projectdiscovery/bugfix-refactor

small refactor
projectdiscovery · Sep 19, 2020 · 786081d · 786081d
2 parents 74f18a1 + 4e6caf5
commit 786081d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 7 deletions.
diff --git a/autofdmax/init_all.go b/autofdmax/init_all.go
diff --git a/autofdmax/init_linux.go b/autofdmax/init_linux.go
@@ -7,5 +7,5 @@ import (
 )
 
 func init() {
-	fdmax.Set(fdmax.Max)
+	fdmax.Set(fdmax.UnixMax)
 }
diff --git a/autofdmax/init_osx.go b/autofdmax/init_osx.go
@@ -0,0 +1,11 @@
+// +build darwin
+
+package autofdmax
+
+import (
+	"github.com/projectdiscovery/fdmax"
+)
+
+func init() {
+	fdmax.Set(fdmax.OSXMax)
+}
diff --git a/autofdmax/init_windows.go b/autofdmax/init_windows.go
@@ -0,0 +1,7 @@
+// +build windows
+
+package autofdmax
+
+func init() {
+	// not implemented
+}
diff --git a/fdmax.go b/fdmax.go
@@ -6,7 +6,8 @@ import (
 )
 
 const (
-	Max uint64 = 999999
+	UnixMax uint64 = 999999
+	OSXMax  uint64 = 24576
 )
 
 type Limits struct {
@@ -28,10 +29,10 @@ func Set(maxLimit uint64) error {
 	var rLimit syscall.Rlimit
 	rLimit.Max = maxLimit
 
-	if runtime.GOOS == "darwin" && rLimit.Cur > 24576 {
-		rLimit.Cur = 24576
-	} else {
-		rLimit.Cur = maxLimit
+	rLimit.Cur = maxLimit
+	// https://github.com/golang/go/issues/30401
+	if runtime.GOOS == "darwin" && rLimit.Cur > OSXMax {
+		rLimit.Cur = OSXMax
 	}
 
 	return syscall.Setrlimit(syscall.RLIMIT_NOFILE, &rLimit)