Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helperfunctions to common Slice operations #50

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

Esonhugh
Copy link
Contributor

This PR is about following example.

E.g.

len(split("https://www.example.com/", ".", -1)) != 3 
// true, the len has toString() make the []string => string first and wrap it with [ and ] and make calc the len => 25

E.g.

(split("https://www.example.com/", '.',-1))[1] == 'example' 
// It has no such expression [n] to get the index[n] string
// and also this expression is not return bool. It make result as []string 

@Esonhugh
Copy link
Contributor Author

@tarunKoyalwar

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@Esonhugh
Copy link
Contributor Author

Great bounds checking

lgtm !

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jun 28, 2023
@Mzack9999 Mzack9999 linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Index helper
3 participants