Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.N.P form for go directive in go.mod file #6787

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

sunjayBhatia
Copy link
Member

To prevent issues with go commands and downloading correct toolchain versions.

See: https://go.dev/doc/toolchain#version

Detected locally when go tool attempted to download a new toolchain for go1.23 and was unable to.

Also see CodeQL warning:
Screenshot 2024-11-25 at 11 42 29 AM

To prevent issues with go commands and downloading correct
toolchain versions.

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 25, 2024
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner November 25, 2024 16:47
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team, davinci26 and izturn and removed request for a team November 25, 2024 16:47
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (4930121) to head (f6dec8b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6787   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         133      133           
  Lines       20026    20026           
=======================================
  Hits        16232    16232           
  Misses       3500     3500           
  Partials      294      294           
---- 🚨 Try these New Features:

@sunjayBhatia sunjayBhatia merged commit d05f43a into main Nov 25, 2024
46 checks passed
@sunjayBhatia sunjayBhatia deleted the go-directive-1.N.P branch November 25, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants