Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testifylint and ginkgo linters #6091

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

sunjayBhatia
Copy link
Member

To ensure more idiomatic test assertions

Was messing around with enabling more linters during some downtime over the break, finished this up this morning

To ensure more idiomatic test assertions

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 16, 2024
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 16, 2024 16:53
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team and davinci26 and removed request for a team January 16, 2024 16:53
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7980bbf) 78.81% compared to head (2c44157) 78.81%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6091   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         138      138           
  Lines       19778    19778           
=======================================
  Hits        15589    15589           
  Misses       3886     3886           
  Partials      303      303           

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia merged commit 02faa3a into projectcontour:main Jan 16, 2024
26 checks passed
@sunjayBhatia sunjayBhatia deleted the enable-testifylint branch January 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants