Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: NamespacedTest helper can create/delete multiple namespaces #5928

Merged

Conversation

satyazzz123
Copy link
Contributor

changed the function signature from func (f *Framework) NamespacedTest(namespace string, body NamespacedTestBody) to this
func (f *Framework) NamespacedTest(namespace string, body NamespacedTestBody, additionalNamespaces ...string)

Updates: #3837

Signed-off-by: satyazzz123 <[email protected]>
@satyazzz123 satyazzz123 requested a review from a team as a code owner November 1, 2023 20:31
@satyazzz123 satyazzz123 requested review from stevesloka and skriss and removed request for a team November 1, 2023 20:31
test/e2e/framework.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 1, 2023

Hi @satyazzz123! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #5928 (90ba48a) into main (c6bc5d9) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5928   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         139      139           
  Lines       19614    19614           
=======================================
  Hits        15410    15410           
  Misses       3901     3901           
  Partials      303      303           

see 9 files with indirect coverage changes

@sunjayBhatia sunjayBhatia changed the title changed function signature test/e2e: NamespacedTest helper can create/delete multiple namespaces Nov 2, 2023
@satyazzz123
Copy link
Contributor Author

@sunjayBhatia is this good to merge? Or I need to make some changes??

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to also use this helper where it is needed in the e2e tests to fully finish #3837

e.g. you can search for CreateNamespace in the test/e2e directory to find where we're manually creating extra namespaces that could be transferred to using this helper

If you want to do that in this PR that would be great, or can be done in a follow up

@satyazzz123
Copy link
Contributor Author

It would be great to also use this helper where it is needed in the e2e tests to fully finish #3837

e.g. you can search for CreateNamespace in the test/e2e directory to find where we're manually creating extra namespaces that could be transferred to using this helper

If you want to do that in this PR that would be great, or can be done in a follow up

If it's not any issue then I can open another PR for the adding the e2e tests using this helper and we can merge this one for the namespaced test. I am working on it right now

@sunjayBhatia sunjayBhatia merged commit f661786 into projectcontour:main Nov 2, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants