-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e: NamespacedTest helper can create/delete multiple namespaces #5928
test/e2e: NamespacedTest helper can create/delete multiple namespaces #5928
Conversation
Signed-off-by: satyazzz123 <[email protected]>
Hi @satyazzz123! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Signed-off-by: satyazzz123 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5928 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 139 139
Lines 19614 19614
=======================================
Hits 15410 15410
Misses 3901 3901
Partials 303 303 |
@sunjayBhatia is this good to merge? Or I need to make some changes?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to also use this helper where it is needed in the e2e tests to fully finish #3837
e.g. you can search for CreateNamespace
in the test/e2e
directory to find where we're manually creating extra namespaces that could be transferred to using this helper
If you want to do that in this PR that would be great, or can be done in a follow up
If it's not any issue then I can open another PR for the adding the e2e tests using this helper and we can merge this one for the namespaced test. I am working on it right now |
changed the function signature from func
(f *Framework) NamespacedTest(namespace string, body NamespacedTestBody)
to thisfunc (f *Framework) NamespacedTest(namespace string, body NamespacedTestBody, additionalNamespaces ...string)
Updates: #3837