Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/go-logr/logr from 1.2.4 to 1.3.0 #5904

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 29, 2023

Bumps github.com/go-logr/logr from 1.2.4 to 1.3.0.

Release notes

Sourced from github.com/go-logr/logr's releases.

v1.3.0

This release adds support for slog in a new, self-contained logr/slogr package. Implementers of a logr.LogSink are encouraged, but not required, to extend their implementation to improve the quality of log output coming from a slog API call.

Breaking change: the call depth for LogSink.Enabled when called via Logger.Enabled was fixed to be the same as for other call paths. Implementers of a LogSink who have worked around this bug will need to remove their workarounds.

Security best practices were improved. Only Go versions >= 1.18 are supported by this release.

What's Changed


New Contributors

... (truncated)

Commits
  • 8adefbe docs: interoperability with slog
  • ebabbb9 build(deps): bump github/codeql-action from 2.22.3 to 2.22.4
  • 9c361f0 build(deps): bump actions/checkout from 4.1.0 to 4.1.1
  • d9b2b78 Merge pull request #229 from go-logr/dependabot/github_actions/github/codeql-...
  • 91cec29 build(deps): bump github/codeql-action from 2.22.0 to 2.22.3
  • 2ea8628 Merge pull request #228 from go-logr/dependabot/github_actions/github/codeql-...
  • 37a4f55 Merge pull request #227 from go-logr/dependabot/github_actions/ossf/scorecard...
  • ecf310c build(deps): bump github/codeql-action from 2.21.9 to 2.22.0
  • d73e05e build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0
  • 1d1c415 Merge pull request #226 from go-logr/dependabot/github_actions/github/codeql-...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested a review from a team as a code owner October 29, 2023 20:03
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. labels Oct 29, 2023
@dependabot dependabot bot requested review from stevesloka, sunjayBhatia and a team and removed request for a team October 29, 2023 20:03
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #5904 (d9ce63b) into main (13d0e36) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5904   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         139      139           
  Lines       19614    19614           
=======================================
  Hits        15410    15410           
  Misses       3901     3901           
  Partials      303      303           

@skriss
Copy link
Member

skriss commented Oct 30, 2023

Breaking change: the call depth for LogSink.Enabled when called via Logger.Enabled was fixed to be the same as for other call paths. Implementers of a LogSink who have worked around this bug will need to remove their workarounds.

Need to take a look at this to see if it's impactful for contour

Fine to hold this for 1.28

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/github.com/go-logr/logr-1.3.0 branch from 02bbc51 to cb08d7e Compare October 30, 2023 14:44
@sunjayBhatia sunjayBhatia added this to the 1.28.0 milestone Oct 30, 2023
@skriss
Copy link
Member

skriss commented Oct 30, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/github.com/go-logr/logr-1.3.0 branch from cb08d7e to 3d831b7 Compare October 30, 2023 23:15
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.2.4 to 1.3.0.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.2.4...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/github.com/go-logr/logr-1.3.0 branch from 3d831b7 to d9ce63b Compare November 1, 2023 14:17
@skriss
Copy link
Member

skriss commented Nov 1, 2023

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2023

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the change noted in the release notes does not look to affect Contour from my read but happy for another set of 👀

@skriss skriss merged commit 6cbb66c into main Nov 1, 2023
26 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/main/github.com/go-logr/logr-1.3.0 branch November 1, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants