Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/envoy: fix wrong check for filter/router #5864

Merged
merged 3 commits into from
Nov 3, 2023
Merged

internal/envoy: fix wrong check for filter/router #5864

merged 3 commits into from
Nov 3, 2023

Conversation

izturn
Copy link
Member

@izturn izturn commented Oct 18, 2023

Signed-off-by: Gang Liu [email protected]

@izturn izturn requested a review from a team as a code owner October 18, 2023 09:52
@izturn izturn requested review from skriss and sunjayBhatia and removed request for a team October 18, 2023 09:52
@izturn izturn self-assigned this Oct 18, 2023
@izturn izturn added kind/bug Categorizes issue or PR as related to a bug. area/infra release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #5864 (d11a51b) into main (dfb9aef) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5864   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files         138      138           
  Lines       19323    19323           
=======================================
  Hits        15176    15176           
  Misses       3855     3855           
  Partials      292      292
Files Coverage Δ
internal/envoy/v3/listener.go 98.50% <100.00%> (ø)

@izturn izturn requested a review from skriss October 19, 2023 07:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023
@izturn izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023
sunjayBhatia
sunjayBhatia approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fails (with panic) w/o this change, thanks!

@sunjayBhatia sunjayBhatia merged commit 5578185 into projectcontour:main Nov 3, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@skriss skriss Awaiting requested review from skriss

Assignees

@izturn izturn

Labels
area/infra kind/bug Categorizes issue or PR as related to a bug. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izturn @skriss @sunjayBhatia