Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump sigs.k8s.io/gateway-api from 0.8.0 to 0.8.1 #5757

Merged
merged 2 commits into from
Sep 21, 2023
Merged

build(deps): bump sigs.k8s.io/gateway-api from 0.8.0 to 0.8.1 #5757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33dc670
build(deps): bump sigs.k8s.io/gateway-api from 0.8.0 to 0.8.1
dependabot[bot] Sep 17, 2023
641d9bb
make generate
skriss Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 86 additions & 2 deletions examples/gateway/00-crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ spec:
for each listener
rule: 'self.all(l1, self.exists_one(l2, l1.port == l2.port && l1.protocol
== l2.protocol && (has(l1.hostname) && has(l2.hostname) ? l1.hostname
== l2.hostname : true)))'
== l2.hostname : !has(l1.hostname) && !has(l2.hostname))))'
required:
- gatewayClassName
- listeners
Expand Down Expand Up @@ -1718,7 +1718,7 @@ spec:
for each listener
rule: 'self.all(l1, self.exists_one(l2, l1.port == l2.port && l1.protocol
== l2.protocol && (has(l1.hostname) && has(l2.hostname) ? l1.hostname
== l2.hostname : true)))'
== l2.hostname : !has(l1.hostname) && !has(l2.hostname))))'
required:
- gatewayClassName
- listeners
Expand Down Expand Up @@ -5845,6 +5845,48 @@ spec:
type: object
maxItems: 8
type: array
timeouts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised this is included in v0.8.1 -- looks like the tag was created on the main branch rather than release-0.8, not sure if that was intentional or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree the changelog and the release branch do not include these commits, something to bring up to the maintainers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like these are going to be left in, since this is the experimental channel and the fields will be included in 1.0 anyway, so I think we're OK to go ahead and merge here.

description: "Timeouts defines the timeouts that can be configured
for an HTTP request. \n Support: Extended \n "
properties:
backendRequest:
description: "BackendRequest specifies a timeout for an
individual request from the gateway to a backend. This
covers the time from when the request first starts being
sent from the gateway to when the full response has been
received from the backend. \n An entire client HTTP transaction
with a gateway, covered by the Request timeout, may result
in more than one call from the gateway to the destination
backend, for example, if automatic retries are supported.
\n Because the Request timeout encompasses the BackendRequest
timeout, the value of BackendRequest must be <= the value
of Request timeout. \n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
request:
description: "Request specifies the maximum duration for
a gateway to respond to an HTTP request. If the gateway
has not been able to respond before this deadline is met,
the gateway MUST return a timeout error. \n For example,
setting the `rules.timeouts.request` field to the value
`10s` in an `HTTPRoute` will cause a timeout if a client
request is taking longer than 10 seconds to complete.
\n This timeout is intended to cover as close to the whole
request-response transaction as possible although an implementation
MAY choose to start the timeout after the entire request
stream has been received instead of immediately after
the transaction is initiated by the client. \n When this
field is unspecified, request timeout behavior is implementation-specific.
\n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
type: object
x-kubernetes-validations:
- message: backendRequest timeout cannot be longer than request
timeout
rule: '!(has(self.request) && has(self.backendRequest) &&
duration(self.request) != duration(''0s'') && duration(self.backendRequest)
> duration(self.request))'
type: object
x-kubernetes-validations:
- message: RequestRedirect filter must not be used together with
Expand Down Expand Up @@ -8244,6 +8286,48 @@ spec:
type: object
maxItems: 8
type: array
timeouts:
description: "Timeouts defines the timeouts that can be configured
for an HTTP request. \n Support: Extended \n "
properties:
backendRequest:
description: "BackendRequest specifies a timeout for an
individual request from the gateway to a backend. This
covers the time from when the request first starts being
sent from the gateway to when the full response has been
received from the backend. \n An entire client HTTP transaction
with a gateway, covered by the Request timeout, may result
in more than one call from the gateway to the destination
backend, for example, if automatic retries are supported.
\n Because the Request timeout encompasses the BackendRequest
timeout, the value of BackendRequest must be <= the value
of Request timeout. \n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
request:
description: "Request specifies the maximum duration for
a gateway to respond to an HTTP request. If the gateway
has not been able to respond before this deadline is met,
the gateway MUST return a timeout error. \n For example,
setting the `rules.timeouts.request` field to the value
`10s` in an `HTTPRoute` will cause a timeout if a client
request is taking longer than 10 seconds to complete.
\n This timeout is intended to cover as close to the whole
request-response transaction as possible although an implementation
MAY choose to start the timeout after the entire request
stream has been received instead of immediately after
the transaction is initiated by the client. \n When this
field is unspecified, request timeout behavior is implementation-specific.
\n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
type: object
x-kubernetes-validations:
- message: backendRequest timeout cannot be longer than request
timeout
rule: '!(has(self.request) && has(self.backendRequest) &&
duration(self.request) != duration(''0s'') && duration(self.backendRequest)
> duration(self.request))'
type: object
x-kubernetes-validations:
- message: RequestRedirect filter must not be used together with
Expand Down
88 changes: 86 additions & 2 deletions examples/render/contour-gateway-provisioner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8985,7 +8985,7 @@ spec:
for each listener
rule: 'self.all(l1, self.exists_one(l2, l1.port == l2.port && l1.protocol
== l2.protocol && (has(l1.hostname) && has(l2.hostname) ? l1.hostname
== l2.hostname : true)))'
== l2.hostname : !has(l1.hostname) && !has(l2.hostname))))'
required:
- gatewayClassName
- listeners
Expand Down Expand Up @@ -9763,7 +9763,7 @@ spec:
for each listener
rule: 'self.all(l1, self.exists_one(l2, l1.port == l2.port && l1.protocol
== l2.protocol && (has(l1.hostname) && has(l2.hostname) ? l1.hostname
== l2.hostname : true)))'
== l2.hostname : !has(l1.hostname) && !has(l2.hostname))))'
required:
- gatewayClassName
- listeners
Expand Down Expand Up @@ -13890,6 +13890,48 @@ spec:
type: object
maxItems: 8
type: array
timeouts:
description: "Timeouts defines the timeouts that can be configured
for an HTTP request. \n Support: Extended \n "
properties:
backendRequest:
description: "BackendRequest specifies a timeout for an
individual request from the gateway to a backend. This
covers the time from when the request first starts being
sent from the gateway to when the full response has been
received from the backend. \n An entire client HTTP transaction
with a gateway, covered by the Request timeout, may result
in more than one call from the gateway to the destination
backend, for example, if automatic retries are supported.
\n Because the Request timeout encompasses the BackendRequest
timeout, the value of BackendRequest must be <= the value
of Request timeout. \n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
request:
description: "Request specifies the maximum duration for
a gateway to respond to an HTTP request. If the gateway
has not been able to respond before this deadline is met,
the gateway MUST return a timeout error. \n For example,
setting the `rules.timeouts.request` field to the value
`10s` in an `HTTPRoute` will cause a timeout if a client
request is taking longer than 10 seconds to complete.
\n This timeout is intended to cover as close to the whole
request-response transaction as possible although an implementation
MAY choose to start the timeout after the entire request
stream has been received instead of immediately after
the transaction is initiated by the client. \n When this
field is unspecified, request timeout behavior is implementation-specific.
\n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
type: object
x-kubernetes-validations:
- message: backendRequest timeout cannot be longer than request
timeout
rule: '!(has(self.request) && has(self.backendRequest) &&
duration(self.request) != duration(''0s'') && duration(self.backendRequest)
> duration(self.request))'
type: object
x-kubernetes-validations:
- message: RequestRedirect filter must not be used together with
Expand Down Expand Up @@ -16289,6 +16331,48 @@ spec:
type: object
maxItems: 8
type: array
timeouts:
description: "Timeouts defines the timeouts that can be configured
for an HTTP request. \n Support: Extended \n "
properties:
backendRequest:
description: "BackendRequest specifies a timeout for an
individual request from the gateway to a backend. This
covers the time from when the request first starts being
sent from the gateway to when the full response has been
received from the backend. \n An entire client HTTP transaction
with a gateway, covered by the Request timeout, may result
in more than one call from the gateway to the destination
backend, for example, if automatic retries are supported.
\n Because the Request timeout encompasses the BackendRequest
timeout, the value of BackendRequest must be <= the value
of Request timeout. \n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
request:
description: "Request specifies the maximum duration for
a gateway to respond to an HTTP request. If the gateway
has not been able to respond before this deadline is met,
the gateway MUST return a timeout error. \n For example,
setting the `rules.timeouts.request` field to the value
`10s` in an `HTTPRoute` will cause a timeout if a client
request is taking longer than 10 seconds to complete.
\n This timeout is intended to cover as close to the whole
request-response transaction as possible although an implementation
MAY choose to start the timeout after the entire request
stream has been received instead of immediately after
the transaction is initiated by the client. \n When this
field is unspecified, request timeout behavior is implementation-specific.
\n Support: Extended"
pattern: ^([0-9]{1,5}(h|m|s|ms)){1,4}$
type: string
type: object
x-kubernetes-validations:
- message: backendRequest timeout cannot be longer than request
timeout
rule: '!(has(self.request) && has(self.backendRequest) &&
duration(self.request) != duration(''0s'') && duration(self.backendRequest)
> duration(self.request))'
type: object
x-kubernetes-validations:
- message: RequestRedirect filter must not be used together with
Expand Down
Loading