api: add kubebuilder-compatible type registration exports #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
==========================================
- Coverage 76.67% 76.60% -0.07%
==========================================
Files 68 68
Lines 5513 5515 +2
==========================================
- Hits 4227 4225 -2
- Misses 1191 1193 +2
- Partials 95 97 +2
|
stevesloka
suggested changes
May 11, 2020
youngnick
suggested changes
May 12, 2020
Restore the kubebuilder-compatible API type registration exports for IngressRoute and HTTPProxy. Keep exporting AddKnownTypes() for projects that already started consuming this symmbol, but note that it is not should no longer be used. This updates projectcontour#2487. Signed-off-by: James Peach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the kubebuilder-compatible API type registration exports for
IngressRoute and HTTPProxy. Keep exporting AddKnownTypes() for projects
that already started consuming this symmbol, but note that it is not
should no longer be used.
This updates #2487.
Signed-off-by: James Peach [email protected]