Dockerfile: upgrade to Go 1.13 #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't pass til Go 1.13 has been released and travis and docker have updated images. ETA for Go 1.13 is before the end of the week. |
davecheney
force-pushed
the
go1.13
branch
4 times, most recently
from
8a46a4b to
16d2abe
Compare
Fixes projectcontour#1377 BREAKING CHANGE We build with -mod=readonly so that the build will fail if anything is out of date in our go.mod file. golang/go#30667 changed the behaviour of the go tool to require that go.mod AND go.sum be up to date so this means I cannot use my hack of .gitignoring the go.sum file. This means when you pull this commit you will probably have to delete your local go.sum working copy. If we're lucky then you shouldn't need to change it after that. If we're not lucky, the bloody thing will always be dirty and we'll waste a lot of time telling people to revert their changes to this file. C'est la vie. Signed-off-by: Dave Cheney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1377
BREAKING CHANGE
We build with -mod=readonly so that the build will fail if anything is
out of date in our go.mod file. golang/go#30667 changed the behaviour of
the go tool to require that go.mod AND go.sum be up to date so this
means I cannot use my hack of .gitignoring the go.sum file.
This means when you pull this commit you will probably have to delete
your local go.sum working copy. If we're lucky then you shouldn't need
to change it after that. If we're not lucky, the bloody thing will
always be dirty and we'll waste a lot of time telling people to revert
their changes to this file. C'est la vie.
Signed-off-by: Dave Cheney [email protected]