Minor fixes to Gateway API conformance on release tag (#5894)

- Don't build/load contour image to kind, we should be using the image we just pushed - Fill in Gateway API version to the report Signed-off-by: Sunjay Bhatia <[email protected]>
projectcontour · Oct 24, 2023 · 6917d85 · 6917d85
1 parent 381c2c5
commit 6917d85
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.github/workflows/build_tag.yaml b/.github/workflows/build_tag.yaml
@@ -71,7 +71,7 @@ jobs:
           GENERATE_GATEWAY_CONFORMANCE_REPORT: "true"
         run: |
           export CONTOUR_E2E_IMAGE="ghcr.io/projectcontour/contour:$(git describe --tags)"
-          make gateway-conformance
+          make setup-kind-cluster run-gateway-conformance cleanup-kind
       - name: Upload gateway conformance report
         uses: actions/upload-artifact@v3
         with:

diff --git a/test/conformance/gatewayapi/gateway_conformance_test.go b/test/conformance/gatewayapi/gateway_conformance_test.go
@@ -116,6 +116,11 @@ func TestGatewayConformance(t *testing.T) {
 
 		report, err := cSuite.Report()
 		require.NoError(t, err, "failed generating conformance report")
+
+		if gwAPIVersion := os.Getenv("GATEWAY_API_VERSION"); gwAPIVersion != "" {
+			report.GatewayAPIVersion = gwAPIVersion
+		}
+
 		rawReport, err := yaml.Marshal(report)
 		require.NoError(t, err)
 		t.Logf("Conformance report:\n%s", string(rawReport))