internal/envoy: remove health check filter from stats listener

Signed-off-by: Rodrigo Chacon <[email protected]>
projectcontour · Sep 6, 2019 · 23e8d26 · 23e8d26
1 parent 43e6422
commit 23e8d26
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 28 deletions.
diff --git a/internal/envoy/stats.go b/internal/envoy/stats.go
@@ -17,7 +17,6 @@ import (
 	v2 "github.com/envoyproxy/go-control-plane/envoy/api/v2"
 	"github.com/envoyproxy/go-control-plane/envoy/api/v2/listener"
 	"github.com/envoyproxy/go-control-plane/envoy/api/v2/route"
-	health_check "github.com/envoyproxy/go-control-plane/envoy/config/filter/http/health_check/v2"
 	http "github.com/envoyproxy/go-control-plane/envoy/config/filter/network/http_connection_manager/v2"
 	"github.com/envoyproxy/go-control-plane/pkg/util"
 	"github.com/gogo/protobuf/types"
@@ -74,19 +73,6 @@ func StatsListener(address string, port int) *v2.Listener {
 							},
 						},
 						HttpFilters: []*http.HttpFilter{{
-							Name: util.HealthCheck,
-							ConfigType: &http.HttpFilter_TypedConfig{
-								TypedConfig: any(&health_check.HealthCheck{
-									PassThroughMode: &types.BoolValue{Value: false},
-									Headers: []*route.HeaderMatcher{{
-										Name: ":path",
-										HeaderMatchSpecifier: &route.HeaderMatcher_ExactMatch{
-											ExactMatch: "/healthz",
-										},
-									}},
-								}),
-							},
-						}, {
 							Name: util.Router,
 						}},
 						NormalizePath: &types.BoolValue{Value: true},

diff --git a/internal/envoy/stats_test.go b/internal/envoy/stats_test.go
@@ -19,7 +19,6 @@ import (
 	v2 "github.com/envoyproxy/go-control-plane/envoy/api/v2"
 	"github.com/envoyproxy/go-control-plane/envoy/api/v2/listener"
 	"github.com/envoyproxy/go-control-plane/envoy/api/v2/route"
-	health_check "github.com/envoyproxy/go-control-plane/envoy/config/filter/http/health_check/v2"
 	http "github.com/envoyproxy/go-control-plane/envoy/config/filter/network/http_connection_manager/v2"
 	"github.com/envoyproxy/go-control-plane/pkg/util"
 	"github.com/gogo/protobuf/types"
@@ -83,19 +82,6 @@ func TestStatsListener(t *testing.T) {
 									},
 								},
 								HttpFilters: []*http.HttpFilter{{
-									Name: util.HealthCheck,
-									ConfigType: &http.HttpFilter_TypedConfig{
-										TypedConfig: any(&health_check.HealthCheck{
-											PassThroughMode: &types.BoolValue{Value: false},
-											Headers: []*route.HeaderMatcher{{
-												Name: ":path",
-												HeaderMatchSpecifier: &route.HeaderMatcher_ExactMatch{
-													ExactMatch: "/healthz",
-												},
-											}},
-										}),
-									},
-								}, {
 									Name: util.Router,
 								}},
 								NormalizePath: &types.BoolValue{Value: true},