Angle vulkan #143
Open
Angle vulkan #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
ceiba1985,
feijiang1,
GangSecurity,
gkdeepa,
renchenglei,
yaoxinshi-intel,
YuanjunHuang and
yyao3
so that the queue count override logic can catch Android system properties. Signed-off-by: Yiwei Zhang <[email protected]> Reviewed-by: Paulo Zanoni <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29492>
Properties from the vendor partition must use a "vendor." prefix from Android T+. Meanwhile the "debug." prefix can be used for local overrides. The order of precedence thus becomes: 1. getenv 2. debug.mesa.* 3. vendor.mesa.* 4. mesa.* (as a fallback for older versions) Tracked-On: OAM-126014 Signed-off-by: Juston Li <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31584>
ANB is only used by Android WSI which uses explicit sync so these flags can be dropped. Signed-off-by: Juston Li <[email protected]> Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29883> (cherry picked from commit 34031e3)
Fall through to common vk_ahb_format_to_image_format() to handle R8G8B8X8 as R8G8B8A8. Fixes issues with querying for format feature support when its handled as R8G8B8. Signed-off-by: Juston Li <[email protected]> Reviewed-by: Yiwei Zhang <[email protected]> Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30080> (cherry picked from commit ef58f24)
Refactor out shared code for the u_gralloc tiling query so it can also be used by ahw and later anb resolves. Signed-off-by: Juston Li <[email protected]> Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29850> (cherry picked from commit bcb17ac)
Like AHB, we don't know the layout for an image backed by gralloc swapchain memory until bind when gralloc information is passed by the platform. Signed-off-by: Juston Li <[email protected]> Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29850> (cherry picked from commit 43cb986)
JeevakaPrabu
force-pushed
the
angle_vulkan
branch
from
e4b15e3 to
0210ccd
Compare
This patch adds the support for AHB to Vulkan format conversion for the pixel format: HAL_PIXEL_FORMAT_NV12_LINEAR_CAMERA_INTEL (271). It is needed to fix the video playback crash seen while enabling ANGLE as the OpenGL ES driver with Vulkan as the backend. Crash Log: 501 517 F libc : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 517 (RenderEngine), pid 501 (surfaceflinger) 2774 2774 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 2774 2774 F DEBUG : Build fingerprint: 'intel/caas/caas:15/AP3A.241005.015.A2/eng.celado.00000000.000000:userdebug/test-keys' 2774 2774 F DEBUG : Revision: '0' 2774 2774 F DEBUG : ABI: 'x86_64' 2774 2774 F DEBUG : Timestamp: 2024-12-10 09:23:54.284397411+0000 2774 2774 F DEBUG : Process uptime: 208s 2774 2774 F DEBUG : Cmdline: /system/bin/surfaceflinger 2774 2774 F DEBUG : pid: 501, tid: 517, name: RenderEngine >>> /system/bin/surfaceflinger <<< 2774 2774 F DEBUG : uid: 1000 2774 2774 F DEBUG : signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr -------- 2774 2774 F DEBUG : Abort message: 'Failed to create a valid texture. [0x71010801e090]:[848,480] isProtected:0 isWriteable:0 format:271' 2774 2774 F DEBUG : rax 0000000000000000 rbx 0000710087a941e8 rcx 0000710318a66b4e rdx 0000000000000006 2774 2774 F DEBUG : r8 0000710087a94f40 r9 0000710087a94f40 r10 0000710087a941f0 r11 0000000000000207 2774 2774 F DEBUG : r12 0000710087a94810 r13 0000000000000000 r14 00000000000001f5 r15 0000000000000205 2774 2774 F DEBUG : rdi 00000000000001f5 rsi 0000000000000205 2774 2774 F DEBUG : rbp 0000000000000000 rsp 0000710087a941e0 rip 0000710318a66b4e Tests done: - Android boot with angle and vulkan as backend - Video playback working correctly - Gallery app is not showing any visual artifacts Tracked-On: OAM-126014 Signed-off-by: Aakash Sarkar <[email protected]>
JeevakaPrabu
force-pushed
the
angle_vulkan
branch
from
0210ccd to
76add79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.