Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build this repo on Yocto and open dGPU for surfaceflinger #130

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

phreer
Copy link
Contributor

@phreer phreer commented Aug 23, 2024

No description provided.

We have some code specific to Android only and it should be built only
on Android so that this code base could possibly be built on GNU/Linux
systems.

Also replace \xC2\xA0 (non-breaking space) with normal space for
consistence.

Signed-off-by: Weifeng Liu <[email protected]>
@sysopenci
Copy link

Dependent pr program name is not compatable this pr's program name, for more details please check tracked_on

@sysopenci
Copy link

Dependent pr program name is not compatable this pr's program name, for more details please check tracked_on

Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

When we have both dGPU and iGPU available, prefer dGPU for compositing
because dGPU can cover more cases for us, e.g., allocating buffers in
device memory.

As a side work, also format the surrounding code for consistency.

Tracked-On: OAM-124060
Signed-off-by: Weifeng Liu <[email protected]>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added the Engineering Build Successful Engineering Build Successful label Aug 28, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 97324f2 into projectceladon:celadon/u/mr0/master Aug 28, 2024
21 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants