-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gfxbench Manhattan3.0 optimization #107
Open
huangrui666
wants to merge
1
commit into
projectceladon:celadon/s/mr0/apollo
Choose a base branch
from
huangrui666:mht_opt
base: celadon/s/mr0/apollo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gfxbench Manhattan3.0 optimization #107
huangrui666
wants to merge
1
commit into
projectceladon:celadon/s/mr0/apollo
from
huangrui666:mht_opt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangrui666
force-pushed
the
mht_opt
branch
2 times, most recently
from
July 8, 2024 02:42
1db5e70
to
7f8c3fb
Compare
feijiang1
reviewed
Jul 8, 2024
sysopenci
requested review from
ceiba1985,
feijiang1,
GangSecurity,
gkdeepa,
renchenglei,
YuanjunHuang and
yyao3
July 8, 2024 06:06
feijiang1
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sysopenci
removed request for
ceiba1985,
renchenglei,
yyao3,
gkdeepa,
YuanjunHuang and
GangSecurity
July 16, 2024 05:59
Eliminate draw call for Manhattan robot shadow when conditions apply. Mark the shadow shader. If the draw call uses the shadow shader and the last operation of its depth texture resource is clear, the draw call can be skiped. The performance of Gfxbench 1080pManhattan3.0 offscreen can be improved 1.5%. Test Done: 1. Boot up and adb reboot 2. Gfxbench Tracked-On: OAM-122053 Signed-off-by: Huang Rui <[email protected]>
sysopenci
requested review from
ceiba1985,
feijiang1,
GangSecurity,
gkdeepa,
renchenglei,
YuanjunHuang and
yyao3
July 17, 2024 05:50
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer Approved
Engineering Build Successful
Engineering Build Successful
Stale
Stale label for inactive open prs
Valid commit message
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate draw call for Manhattan robot shadow when conditions apply. The performance of Gfxbench Manhattan3.0 offsreen can be improved 2.4%
Tracked-On: OAM-122053