Skip to content

Commit

Permalink
Fixed a DEQP bug on DG2
Browse files Browse the repository at this point in the history
For RGB565D0S0MS0,some pixels will be cleared incorrectly,
when using the REP16 instruction on the DG2 platform to accelerate slow clear.
Ref link: https://hsdes.intel.com/appstore/article-one/article/14017880152.
For example, with glClear(0.125, 0.25, 0.5, 1), the corresponding pixel values are (32, 64, 128).
When using the REP16 instruction on the DG2 platform to accelerate slow clear,
some pixels will be cleared to (24, 60, 120).

Tracked-On: OAM-123699
Signed-off-by: Li,Gaoshun [email protected]
  • Loading branch information
gaoshunli committed Dec 25, 2024
1 parent 74d2263 commit 9e117f7
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/intel/blorp/blorp_clear.c
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,14 @@ blorp_clear(struct blorp_batch *batch,
format == ISL_FORMAT_R10G10B10_FLOAT_A2_UNORM)
use_simd16_replicated_data = false;

/* For RGB565D0S0MS0,some pixels will be cleared incorrectly,
* when using the REP16 instruction on the DG2 platform to accelerate slow clear.
* Ref link: https://hsdes.intel.com/appstore/article-one/article/14017880152.
*/
if (batch->blorp->isl_dev->info->verx10 == 125 &&
format == ISL_FORMAT_B5G6R5_UNORM)
use_simd16_replicated_data = false;

if (compute)
use_simd16_replicated_data = false;

Expand Down

0 comments on commit 9e117f7

Please sign in to comment.