Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wifi ap/sta dual mode config in wlan/BoardConfig #1753

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

zhaoye1
Copy link
Contributor

@zhaoye1 zhaoye1 commented Sep 25, 2023

Add in below:
device/intel/mixins/groups/wlan/iwlwifi/BoardConfig.mk not:
device/intel/project-celadon/celadon_ivi/BoardConfig.mk

Tracked-On: OAM-112365

@sysopenci
Copy link

Improper Commit Message
Valid Commit Message
Improper Jira Status,
jira status not in ['In Progress','Implemented']

Copy link

@maozhong1 maozhong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add in below:
device/intel/mixins/groups/wlan/iwlwifi/BoardConfig.mk
not:
device/intel/project-celadon/celadon_ivi/BoardConfig.mk

Tracked-On: OAM-112365
Signed-off-by: Zhao Ye <[email protected]>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

Copy link
Contributor

@lchen43 lchen43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'preintegration' builder

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/672

Done by "Ye, Zhao" [email protected]

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'premerge' builder

More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/396

Done by "Ye, Zhao" [email protected]

sysopenci pushed a commit to projectceladon/device-androidia that referenced this pull request Sep 26, 2023
Fix for sepolicy blocking iw in creating wifi AP interface
iw is not able to create Wi-Fi AP interface due to sepolicy.
As iw is built as system package, addition of sepolicy requires
changes to system/sepolicy which is not recommended. So, using
the vendor iw package instead of system iw package.
Add wifi ap/sta dual mode config in wlan/BoardConfig
Add in below:
device/intel/mixins/groups/wlan/iwlwifi/BoardConfig.mk
not:
device/intel/project-celadon/celadon_ivi/BoardConfig.mk

Tracked-On: OAM-112365
Tracked-On: OAM-112388
Mixin-Reviewed-On: projectceladon/device-androidia-mixins#1753
Mixin-Reviewed-On: projectceladon/device-androidia-mixins#1755
Signed-off-by: Zhao Ye <[email protected]>
@sysopenci sysopenci merged commit 2fd4ac0 into projectceladon:celadon/s/mr0/master Sep 26, 2023
sysopenci pushed a commit to projectceladon/device-androidia that referenced this pull request Sep 26, 2023
Fix for sepolicy blocking iw in creating wifi AP interface
iw is not able to create Wi-Fi AP interface due to sepolicy.
As iw is built as system package, addition of sepolicy requires
changes to system/sepolicy which is not recommended. So, using
the vendor iw package instead of system iw package.
Add wifi ap/sta dual mode config in wlan/BoardConfig
Add in below:
device/intel/mixins/groups/wlan/iwlwifi/BoardConfig.mk
not:
device/intel/project-celadon/celadon_ivi/BoardConfig.mk

Tracked-On: OAM-112365
Tracked-On: OAM-112388
Mixin-Reviewed-On: projectceladon/device-androidia-mixins#1753
Mixin-Reviewed-On: projectceladon/device-androidia-mixins#1755
Signed-off-by: Zhao Ye <[email protected]>
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cactus finished building and testing your changes

It was requested for merge by "Ye, Zhao" [email protected]

so we merge it. Thanks for your contribution.

more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants