Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update golang to 1.19 #759

Merged
merged 4 commits into from
May 17, 2023

Conversation

slimm609
Copy link
Contributor

@slimm609 slimm609 commented May 10, 2023

update capsule to golang 1.19 to allow for easier recompile using boringcrypto which was added to main in golang 1.19

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 5693e97
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/646220b54addbd000802b96f

@prometherion prometherion added this to the v0.3.2 milestone May 11, 2023
@prometherion
Copy link
Member

Hey @slimm609, thanks for the fix!

It would be great to split the changes into three separate commits if you don't mind, something as:

chore(build): golang 1.19 update
chore(gh): golang 1.19 update
docs: golang 1.19 requirement

We're following the semantic commit messages guidelines

@slimm609
Copy link
Contributor Author

slimm609 commented May 11, 2023

@prometherion what is the reason for multiple PRs? They are direct dependencies of each other. That would be like saying split the update of library A and Library B into 2 PRs even though they directly depend on each other. If the update of B is required for update A to work properly, they shouldn't be split into multiple PRs. If the CI pipeline is 1.19 and the image is 1.18, that's not a valid CI test as its not an accurate test of what the build would produce.

@slimm609 slimm609 force-pushed the update_golang_1_19 branch from 2db52bd to 368431a Compare May 15, 2023 11:53
@slimm609 slimm609 force-pushed the update_golang_1_19 branch from 368431a to 5693e97 Compare May 15, 2023 12:08
@slimm609
Copy link
Contributor Author

updated

@slimm609
Copy link
Contributor Author

@prometherion this should be good now

@prometherion
Copy link
Member

e2e tests are flaky on GH, we can get this merged.

Thanks for the contribution, @slimm609! 🚀

@prometherion prometherion merged commit 9d06f68 into projectcapsule:master May 17, 2023
@meetdpv
Copy link

meetdpv commented May 30, 2023

When are we expecting to release v0.3.2 to be available with the updated docker images?

@prometherion
Copy link
Member

@meetdpv once we have the milestone completed, I'll cut off a new version.

@meetdpv
Copy link

meetdpv commented Jun 1, 2023

Thanks. That's great to hear. Could you please let us know the estimated timeline because if it is pushed to a month, we won't be able to whitelist Capsule image from security team in order to take it to Prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants