-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update golang to 1.19 #759
fix: update golang to 1.19 #759
Conversation
✅ Deploy Preview for capsule-documentation canceled.
|
Hey @slimm609, thanks for the fix! It would be great to split the changes into three separate commits if you don't mind, something as:
We're following the semantic commit messages guidelines |
@prometherion what is the reason for multiple PRs? They are direct dependencies of each other. That would be like saying split the update of library A and Library B into 2 PRs even though they directly depend on each other. If the update of B is required for update A to work properly, they shouldn't be split into multiple PRs. If the CI pipeline is 1.19 and the image is 1.18, that's not a valid CI test as its not an accurate test of what the build would produce. |
2db52bd
to
368431a
Compare
368431a
to
5693e97
Compare
updated |
@prometherion this should be good now |
e2e tests are flaky on GH, we can get this merged. Thanks for the contribution, @slimm609! 🚀 |
When are we expecting to release v0.3.2 to be available with the updated docker images? |
Thanks. That's great to hear. Could you please let us know the estimated timeline because if it is pushed to a month, we won't be able to whitelist Capsule image from security team in order to take it to Prod? |
update capsule to golang 1.19 to allow for easier recompile using boringcrypto which was added to main in golang 1.19