-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: defaults handler for ingress, pods and pvcs #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm not getting the point here: if we define a mutating webhook for these fields, we should be able to respond with a mutating response that would be executed by the API Server, as we're doing with Namespaces. Am I missing something else? |
prometherion
reviewed
Jan 5, 2023
oliverbaehler
force-pushed
the
issues/610
branch
from
January 5, 2023 16:27
c3071e0
to
8c0a72f
Compare
oliverbaehler
changed the title
feat: defaults handler for Ingress, pods and pvcs
feat: defaults handler for ingress, pods and pvcs
Jan 5, 2023
prometherion
requested changes
Jan 7, 2023
prometherion
force-pushed
the
issues/610
branch
from
January 13, 2023 19:56
8c0a72f
to
d192171
Compare
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
prometherion
force-pushed
the
issues/610
branch
from
January 13, 2023 20:06
d192171
to
c87dc2a
Compare
prometherion
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements #610
Required some code refactoring to keep code as clean as possible.
Here's some notes for the review:
Default
is defined, it's automatically allowed within a tenant. The default value does not have to be explicit allowed (Better User-Experience).Ingress
.PVCs
andPods
can not be patched on the relevant fields, which would cause a default mutation.IngressClass
only supported on APInetworking/v1
. Feature supported forIngress
onnetworking
v1
andv1beta1
StorageClass
only supported on APIstorage/v1
PriorityClass
only supported on APIschedule/v1