-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First implementation for label selector for Ingress, Storage and Priority classes #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
prometherion
force-pushed
the
issues/436
branch
2 times, most recently
from
December 26, 2022 13:38
ce2cba1
to
c2147bc
Compare
prometherion
changed the title
First implementation for label selector for Ingress, Storage and Priority classes.
First implementation for label selector for Ingress, Storage and Priority classes
Dec 26, 2022
prometherion
force-pushed
the
issues/436
branch
from
December 26, 2022 13:45
c2147bc
to
8216112
Compare
prometherion
commented
Dec 27, 2022
prometherion
commented
Dec 27, 2022
oliverbaehler
force-pushed
the
issues/436
branch
from
December 27, 2022 15:19
7a9d85f
to
74b8390
Compare
Signed-off-by: Oliver Bähler <[email protected]>
prometherion
force-pushed
the
issues/436
branch
from
December 27, 2022 16:21
14a5b45
to
6493ecf
Compare
oliverbaehler
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436.
This feature cannot be backported to
v1beta1
and all the Tenant instances must be persisted first asv1beta2
due to the complexity of storing thematchLabels
and thematchRequirements
data structure.Aong with that,
v1beta2
is marked as the storage version for the upcoming Capsule release.