Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation for label selector for Ingress, Storage and Priority classes #673

Merged
merged 17 commits into from
Dec 27, 2022

Conversation

prometherion
Copy link
Member

@prometherion prometherion commented Dec 26, 2022

Closes #436.

This feature cannot be backported to v1beta1 and all the Tenant instances must be persisted first as v1beta2 due to the complexity of storing the matchLabels and the matchRequirements data structure.

Aong with that, v1beta2 is marked as the storage version for the upcoming Capsule release.

@netlify
Copy link

netlify bot commented Dec 26, 2022

Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 6493ecf
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/63ab1b87ea55280008eb02ec

@prometherion prometherion force-pushed the issues/436 branch 2 times, most recently from ce2cba1 to c2147bc Compare December 26, 2022 13:38
@prometherion prometherion changed the title First implementation for label selector for Ingress, Storage and Priority classes. First implementation for label selector for Ingress, Storage and Priority classes Dec 26, 2022
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@oliverbaehler oliverbaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prometherion prometherion merged commit ee0fdc9 into master Dec 27, 2022
@prometherion prometherion deleted the issues/436 branch December 27, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use selectors instead of AllowedList for IngressClasses, StorageClasses, PriorityClasses
2 participants