Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1beta2 API support and replicating resources across Tenant namespaces #644

Merged
merged 26 commits into from
Nov 23, 2022
Merged

v1beta2 API support and replicating resources across Tenant namespaces #644

merged 26 commits into from
Nov 23, 2022

Conversation

prometherion
Copy link
Member

@prometherion prometherion commented Sep 22, 2022 •
edited
Loading

@netlify
Copy link

netlify bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit f2319c0
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/637bbd2bfa69d60008ca90db

@prometherion prometherion force-pushed the v1beta2 branch 5 times, most recently from 2603431 to 39fbfa0 Compare September 27, 2022 16:28
@prometherion prometherion marked this pull request as ready for review September 27, 2022 16:28
@prometherion prometherion mentioned this pull request Sep 27, 2022
Closed
@prometherion prometherion changed the title First porting for v1beta2 v1beta2 API support an TenantResource Oct 4, 2022
@prometherion prometherion force-pushed the v1beta2 branch 5 times, most recently from 0fcd704 to 8475ec1 Compare October 8, 2022 15:58
@prometherion prometherion force-pushed the v1beta2 branch 2 times, most recently from fea9807 to f85149b Compare October 13, 2022 14:05
@prometherion
Copy link
Member Author

@MaxFedotov PTAL, tests are flaky and locally seem working, along with the new e2e tests.

I'm not promoting v1beta2 as the new stored version in etcd since we're waiting for first feature proposed with #436: do you agree?

@prometherion prometherion changed the title v1beta2 API support an TenantResource v1beta2 API support and replicating resources across Tenant namespaces Oct 13, 2022
@prometherion prometherion mentioned this pull request Oct 14, 2022
Closed
@bsctl
Copy link
Member

bsctl commented Oct 14, 2022

@prometherion it seems to me that #222 can be solved by this PR too.

@prometherion prometherion force-pushed the v1beta2 branch 5 times, most recently from a0193d1 to e9a96e2 Compare October 20, 2022 10:08
@prometherion
Copy link
Member Author

@MaxFedotov I addressed all your required changes, please, could you take a look again?

@prometherion
Copy link
Member Author

@MaxFedotov we should be there, my bad, I missed all the requested changes due to the GH UI.

This is a huge PR, keep in mind we're not yet moving to the v1beta2 as the storage version, with that said, I think we could get this merged, and if we find issues or typos, fix them, also considering we're going to switch the default type to the latest one with #652.

@MaxFedotov
Copy link
Collaborator

@MaxFedotov we should be there, my bad, I missed all the requested changes due to the GH UI.

This is a huge PR, keep in mind we're not yet moving to the v1beta2 as the storage version, with that said, I think we could get this merged, and if we find issues or typos, fix them, also considering we're going to switch the default type to the latest one with #652.

Thanks, @prometherion!
All good, except
https://github.com/clastix/capsule/blob/25ce8aa9cf0b755ea53bab106e7e11c0a6373bf0/api/v1beta2/tenant_conversion_hub.go#L108
It should be

in.Spec.IngressOptions.AllowedHostnames = hostnames

prometherion and others added 18 commits November 21, 2022 19:02
@prometherion
refactor: abstracting types used by several api versions
aca062f
@prometherion
chore(lint): adding goheader rule and removing unused ones
f4ae20a
@prometherion
style: conforming go files headers
92a1b09
@prometherion
refactor: using interfaces for accessing tenant namespaces
81206c1
@prometherion
feat(api): globaltenantresource and tenantresource support
d11910b
@prometherion
chore(kustomize): globaltenantresource and tenantresource support
6a0de88
@prometherion
chore(helm)!: globaltenantresource and tenantresource support
0fb2df9
@prometherion
feat: globaltenantresource and tenantresource reconciliation
8cbdecf
@prometherion
test: globaltenantresource and tenantresource support
5076393
@prometherion
docs: globaltenantresource and tenantresource support
f3d3160
@prometherion
refactor(test): generating namespace names avoiding collision
ac073f5
@MaxFedotov @prometherion
feat: refactor resources controller
682862b 
Co-authored-by: Maksim Fedotov <[email protected]>
@prometherion
refactor: deprecating tenant v1alpha1 version
a2f1dc7
@prometherion
style: kubebuilder annotations start with empty space
c7b6636
@prometherion
chore(helm)!: release of v0.2.0
4f71650
@prometherion
feat: support for kubernetes 1.25
f0032e4
@prometherion
test: support for endpointslice/v1 for k8s v1.25
a1910fa
@prometherion
fix(makefile): avoid race condition for local kind cluster
f2319c0
@prometherion
Copy link
Member Author

Thanks @MaxFedotov , I love you for the great review work you put in place! ❤️

Everything should be settled, fingers crossed for your review! 🤞🏻

MaxFedotov
MaxFedotov approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@MaxFedotov MaxFedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prometherion prometherion changed the base branch from master to releases/v0.2.0 November 23, 2022 17:16
@prometherion
Copy link
Member Author

Going to merge this into a development branch that will be merged to master once ready for the final release.

@prometherion prometherion merged commit 61b1a4c into releases/v0.2.0 Nov 23, 2022
@prometherion prometherion deleted the v1beta2 branch November 23, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxFedotov MaxFedotov MaxFedotov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@prometherion @bsctl @MaxFedotov