Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: protected tenant annotation #566

Merged
merged 3 commits into from
May 18, 2022
Merged

feat: protected tenant annotation #566

merged 3 commits into from
May 18, 2022

Conversation

MaxFedotov
Copy link
Collaborator

closes #563

@MaxFedotov MaxFedotov requested a review from prometherion May 16, 2022 17:13
@netlify
Copy link

netlify bot commented May 16, 2022 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 8fe0640
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/62838d12161ef7000839c14e

prometherion
prometherion requested changes May 16, 2022
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a brief description of this feature in the documentation with a proper commit.

Overall, LGTM!

@MaxFedotov
Copy link
Collaborator Author

@prometherion can you please take a look at tests? don't know why they are failing randomly

prometherion
prometherion requested changes May 17, 2022
View reviewed changes
pkg/webhook/tenant/protected.go Outdated Show resolved Hide resolved
@prometherion prometherion merged commit 3c9228d into projectcapsule:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation to protect tenant from accidental deletion
2 participants
@MaxFedotov @prometherion