style: removing unused struct fields #556
Conversation
✅ Deploy Preview for capsule-documentation canceled.
|
|
Hey @TinySong, thanks for opening your first PR for Capsule! Could you elaborate a bit more what's the issue you faced? Actually, we got CI and automated tests and expect Capsule to run on Linux-based machines. |
| return nil | ||
| return retryErr |
There was a problem hiding this comment.
This is definitely a bug, returning the error from the upperscope.
Wondering how this is blocking the build as reported in the PR title.
There was a problem hiding this comment.
thank you reply so quickly. I just recently finding a multi-tenant solution in Kubernetes. then I find capsule, I think capsule is Very accord with my expectations. then Clone the code, and execute make command. output the error
mesage:
~/development/golang/src/capsule/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
golangci-lint run -c .golangci.yml
pkg/webhook/tenant/custom_resource_quota.go:80:5: error is not nil (line 79) but it returns nil (nilerr)
return nil
^
controllers/servicelabels/abstract.go:31:2: `scheme` is unused (structcheck)
scheme *runtime.Scheme
^
make: *** [golint] Error 1
There was a problem hiding this comment.
maybe I should remove macOS in the title of the PR?
There was a problem hiding this comment.
Yes, please, although is very weird since we got automation.
Anyway, great finding! 👍🏻
There was a problem hiding this comment.
remove on macOS in the git message.
There was a problem hiding this comment.
Your PR seems broken and that's right because we should create a sentinel error for the function capsulev1beta1.GetLimitResourceFromTenant.
I already opened #564 with a related fix that has been merged, please rebase over master.
bobsongplus
changed the title
|
@TinySong I still see the old commit message, please, could you amend |
bobsongplus
changed the title
@prometherion update git message of PR and rebase the latest code. |
/kind cleanup
/kind bug