Forbidden node labels and annotations #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFedotov
force-pushed
the
issues/435
branch
2 times, most recently
from
01dd8ff to
3f8fdc4
Compare
|
@prometherion need your help with tests because it is weird :( But on github workflows always got an error like |
MaxFedotov
force-pushed
the
issues/435
branch
4 times, most recently
from
359d768 to
319c8fd
Compare
|
@prometherion damn, I found out what going on with tests on 1.16 (that is the same issue I've discussed some time ago with guys from Kyverno on their slack) - we hit this kubernetes/kubernetes#100096 And as this regression isn't fixed for 1.16 and 1.17 I really don't know what to do with them - either drop their support (which may seem reasonable as these versions are obsolete for not) or just don't add this node webhook on versions that do not have this fix. |
MaxFedotov
force-pushed
the
issues/435
branch
from
03819a0 to
2f20fc7
Compare
|
ok, I was able to disable this webhook for versions that don't have a fix for CVE-2021-25735. @prometherion waiting for your review. |
prometherion
approved these changes
Oct 30, 2021
|
@prometherion i was on vacations, will fix everything you mentioned and merge it today in the evening |
added 13 commits
November 2, 2021 19:48
MaxFedotov
force-pushed
the
issues/435
branch
from
2f20fc7 to
2b0b54d
Compare
unai-ttxu
pushed a commit
to unai-ttxu/capsule
that referenced
this pull request
Jun 3, 2022
* feat: forbidden node labels and annotations * test(e2e): forbidden node labels and annotations * build(kustomize): forbidden node labels and annotations * build(helm): forbidden node labels and annotations * build(installer): forbidden node labels and annotations * chore(make): forbidden node labels and annotations * docs: forbidden node labels and annotations * test(e2e): forbidden node labels and annotations. Use EventuallyCreation func * feat: forbidden node labels and annotations. Check kubernetes version * test(e2e): forbidden node labels and annotations. Check kubernetes version * docs: forbidden node labels and annotations. Version restrictions * feat: forbidden node labels and annotations. Do not update deepcopy functions * docs: forbidden node labels and annotations. Use blockquotes for notes Co-authored-by: Maksim Fedotov <[email protected]>
unai-ttxu
added a commit
to unai-ttxu/capsule
that referenced
this pull request
Jun 3, 2022
This reverts commit cadcb9e.
unai-ttxu
added a commit
to unai-ttxu/capsule
that referenced
this pull request
Jun 3, 2022
* feat: forbidden node labels and annotations * test(e2e): forbidden node labels and annotations * build(kustomize): forbidden node labels and annotations * build(helm): forbidden node labels and annotations * build(installer): forbidden node labels and annotations * chore(make): forbidden node labels and annotations * docs: forbidden node labels and annotations * test(e2e): forbidden node labels and annotations. Use EventuallyCreation func * feat: forbidden node labels and annotations. Check kubernetes version * test(e2e): forbidden node labels and annotations. Check kubernetes version * docs: forbidden node labels and annotations. Version restrictions * feat: forbidden node labels and annotations. Do not update deepcopy functions * docs: forbidden node labels and annotations. Use blockquotes for notes Co-authored-by: Maksim Fedotov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #435