Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make programmable deny of wildcard hostnames #417

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Make programmable deny of wildcard hostnames #417

merged 3 commits into from
Sep 21, 2021

Conversation

alegrey91
Copy link
Contributor

Closes #219

@alegrey91 alegrey91 changed the title Draft: Make programmable deny of wildcard hostnames Make programmable deny of wildcard hostnames Sep 14, 2021
@alegrey91 alegrey91 force-pushed the issue/219 branch 4 times, most recently from b1f2707 to 25524ae Compare September 16, 2021 14:08
@MaxFedotov
Copy link
Collaborator

MaxFedotov commented Sep 16, 2021 •
edited
Loading

@alegrey91 @prometherion Hey! And why not to add denyWildcard to spec.IngressOptions instead of using annotations, as this would be backward-compatible change?

prometherion
prometherion reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at changes everything seems good, however we got failing tests on ingressClass check, still investigating why this happens.

@prometherion
Copy link
Member

@alegrey91 @prometherion Hey! And why not to add denyWildcard to spec.IngressOptions instead of using annotations, as this would be backward-compatible change?

That would require a CRD change, requiring a new minor release: idea is to use the annotations, and then prepare the struct change for the new API version.

Does it sound good to you, @MaxFedotov ?

prometherion
prometherion approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are flaky but not related to the following changes.

@prometherion prometherion merged commit 357834c into master Sep 21, 2021
@prometherion prometherion deleted the issue/219 branch September 21, 2021 17:14
@prometherion prometherion mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make programmable deny of wildcard hostnames
3 participants
@alegrey91 @MaxFedotov @prometherion