Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod PriorityClass proxy operation support #352

Merged
merged 4 commits into from
Jul 21, 2021
Merged

Pod PriorityClass proxy operation support #352

merged 4 commits into from
Jul 21, 2021

Conversation

prometherion
Copy link
Member

Closes #257, finally.

@MaxFedotov may I ask you if it's ok since you take care of the proxy actions?

@MaxFedotov
Copy link
Collaborator

lgtm, but can you please also add tests for PriorityClasses here: https://github.com/clastix/capsule/blob/master/api/v1alpha1/conversion_hub_test.go#L129

@prometherion
Copy link
Member Author

Thanks a lot @MaxFedotov, there was a bug and writing the test case helped me to find out.

Copy link
Collaborator

@MaxFedotov MaxFedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@prometherion prometherion merged commit c0d4aab into master Jul 21, 2021
@prometherion prometherion deleted the issues/257 branch July 21, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign Priority Classes to tenants
2 participants