Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CapsuleConfiguration CRD #269

Merged
merged 13 commits into from
May 31, 2021
Merged

CapsuleConfiguration CRD #269

merged 13 commits into from
May 31, 2021

Conversation

prometherion
Copy link
Member

@prometherion prometherion commented May 30, 2021

Closes #122.

Rather than dealing with CLI flags, a new CRD is introduced.

apiVersion: capsule.clastix.io/v1alpha1
kind: CapsuleConfiguration
metadata:
  name: default
spec:
  userGroups: ["capsule.clastix.io"]
  forceTenantPrefix: false
  protectedNamespaceRegex: ""
  allowTenantIngressHostnamesCollision: false
  allowIngressHostnameCollision: false

All the options from CLI have been hardly deprecated, substituted with the new CRD reference (--configuration-name=default).

This is absolutely a breaking change but it's required to ship the 0.1.0 release.

We should have also good news regarding e2e testing since the configuration reloads is at runtime, allowing to skip the Pod respawning.

@prometherion prometherion self-assigned this May 30, 2021
@prometherion prometherion requested a review from bsctl May 30, 2021 20:45
@prometherion prometherion force-pushed the issues/122 branch 3 times, most recently from 8a17bf7 to 0287742 Compare May 30, 2021 21:14
@prometherion
Copy link
Member Author

Tests are running in ~6.30 minutes, we halved the average execution! 😎 🚀

@bsctl
Copy link
Member

bsctl commented May 31, 2021

@prometherion amazing work.

@MaxFedotov
Copy link
Collaborator

@prometherion wow, that's great job!

Copy link
Member

@bsctl bsctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prometherion LGTM!!!

@prometherion prometherion merged commit a7fff59 into master May 31, 2021
@prometherion prometherion deleted the issues/122 branch May 31, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capsule configuration via a CRDs
3 participants