-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CapsuleConfiguration CRD #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometherion
force-pushed
the
issues/122
branch
3 times, most recently
from
May 30, 2021 21:14
8a17bf7
to
0287742
Compare
Tests are running in ~6.30 minutes, we halved the average execution! 😎 🚀 |
@prometherion amazing work. |
@prometherion wow, that's great job! |
bsctl
reviewed
May 31, 2021
bsctl
reviewed
May 31, 2021
bsctl
reviewed
May 31, 2021
bsctl
approved these changes
May 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prometherion LGTM!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122.
Rather than dealing with CLI flags, a new CRD is introduced.
All the options from CLI have been hardly deprecated, substituted with the new CRD reference (
--configuration-name=default
).This is absolutely a breaking change but it's required to ship the 0.1.0 release.
We should have also good news regarding e2e testing since the configuration reloads is at runtime, allowing to skip the Pod respawning.